On 21/06/2024 20:13, Dragan Simic wrote: > Hello Krzysztof, > > On 2024-06-21 11:57, Krzysztof Kozlowski wrote: >> On 21/06/2024 03:25, Daniel Golle wrote: >>> From: Aurelien Jarno <aurelien@xxxxxxxxxxx> > > [snip] > >>> + pm_runtime_set_autosuspend_delay(dev, RK_RNG_AUTOSUSPEND_DELAY); >>> + pm_runtime_use_autosuspend(dev); >>> + pm_runtime_enable(dev); >>> + >>> + ret = devm_hwrng_register(dev, &rk_rng->rng); >>> + if (ret) >>> + return dev_err_probe(&pdev->dev, ret, "Failed to register Rockchip >>> hwrng\n"); >>> + >>> + dev_info(&pdev->dev, "Registered Rockchip hwrng\n"); >> >> Drop, driver should be silent on success. > > I respectfully disagree. Many drivers print a single line upon > successful probing, which I find very useful. In this particular No, it's duplicating existing interfaces and polluting log unnecessarily without any useful information. > case, it's even more useful, because some people may be concerned > about the use of hardware TRNGs, so we should actually make sure > to announce it. Best regards, Krzysztof
