Re: [PATCH] hwrng: core - Fix wrong quality calculation at hw rng registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 21, 2024 at 11:54:59AM +0200, Harald Freudenberger wrote:
>
> @@ -545,8 +546,14 @@ int hwrng_register(struct hwrng *rng)
>  	complete(&rng->cleanup_done);
>  	init_completion(&rng->dying);
>  
> +	/* Quality field not set in struct hwrng means 1024 */
> +	rng_quality = rng->quality ? rng->quality : 1024;
> +	cur_quality = current_rng ?
> +		(current_rng->quality ? current_rng->quality : 1024) :
> +		0;

The number 1024 is meant to be user configurable.  We sould move
the rng->quality initialisation from hwrng_init to hwrng_register.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux