Hi,
On Friday, 21 June 2024 03:25:18 CEST Daniel Golle wrote:
> diff --git a/drivers/char/hw_random/rockchip-rng.c
> b/drivers/char/hw_random/rockchip-rng.c new file mode 100644
> index 000000000000..6070abb73847
> --- /dev/null
> +++ b/drivers/char/hw_random/rockchip-rng.c
> @@ -0,0 +1,229 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * rockchip-rng.c True Random Number Generator driver for Rockchip SoCs
> + *
> + * Copyright (c) 2018, Fuzhou Rockchip Electronics Co., Ltd.
> + * Copyright (c) 2022, Aurelien Jarno
> + * Authors:
> + * Lin Jinhan <troy.lin@xxxxxxxxxxxxxx>
> + * Aurelien Jarno <aurelien@xxxxxxxxxxx>
> + */
> +#include <linux/clk.h>
> +#include <linux/hw_random.h>
> +#include <linux/io.h>
> +#include <linux/iopoll.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of_platform.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/reset.h>
> +#include <linux/slab.h>
I've been using a modified version of Aurelien's patch myself and I added the
following to my commit description:
```
hwrng: rockchip: Explicitly include correct DT includes
Similar to commit
045a44d4c9b3 ("regulator: Explicitly include correct DT includes")
replace ``of_platform.h`` include with ``of.h`` and ``platform_device.h``.
Link: https://git.kernel.org/linus/045a44d4c9b32578aacf0811063e5bb741c7c32c
```
BUT I don't (really) know what I'm doing, so could you verify whether there is
some merit to it?
Cheers,
DiederikAttachment:
signature.asc
Description: This is a digitally signed message part.
