On Thu, Jun 06, 2024 at 11:11:13AM +0200, Marek Behún wrote: > On Wed, 5 Jun 2024 22:00:20 +0300 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > > +#include <linux/bitfield.h> > > > +#include <linux/completion.h> > > > > + errno.h > > I use -EIO, -EINVAL and -ENOMEM in turris-omnia-mcu-base.c, > -EINVAL, -ENOTSUPP in turris-omnia-mcu-gpio.c. > Should I include errno.h in those also? If you have err.h, then no (it includes asm/errno.h), otherwise, yes. > Or is this only needed for -ERESTARTSYS? Definitely yes for Linux internal error codes (>= 512). Note, that ENOTSUPP is also Linux internal code. -- With Best Regards, Andy Shevchenko
