On Sat May 11, 2024 at 9:23 AM EEST, Joachim Vandersmissen wrote: > v4: FIPS_SIGNATURE_SELFTEST_RSA is no longer user-configurable and will > be set when the dependencies are fulfilled. > > ---8<--- This is in wrong place. If the patch is applied it will be included to the kernel git log. Please put your log before diffstat. > In preparation of adding new ECDSA self-tests, the existing data is > moved to a separate file. A new configuration option is added to > control the compilation of the separate file. This configuration option > also enforces dependencies that were missing from the existing > CONFIG_FIPS_SIGNATURE_SELFTEST option. 1. Please just call the thing by its name instead of building tension with "the new configuration option". 2. Lacks the motivation of adding a new configuration option. > The old fips_signature_selftest is no longer an init function, but now > a helper function called from fips_signature_selftest_rsa. This is confusing, please remove. So why just send this and not this plus the selftest? Feels incomplete to me. BR, Jarkko
