Hi Herbert,
On 5/10/24 3:15 AM, Herbert Xu wrote:
On Thu, May 02, 2024 at 11:38:56PM -0500, Joachim Vandersmissen wrote:
diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
index 59ec726b7c77..68434c745b3c 100644
--- a/crypto/asymmetric_keys/Kconfig
+++ b/crypto/asymmetric_keys/Kconfig
@@ -86,4 +86,14 @@ config FIPS_SIGNATURE_SELFTEST
depends on PKCS7_MESSAGE_PARSER=X509_CERTIFICATE_PARSER
depends on X509_CERTIFICATE_PARSER
+config FIPS_SIGNATURE_SELFTEST_RSA
+ bool "Include RSA selftests"
Please don't ask questinons in Kconfig that we can avoid. In
this case I see no valid reason for having this extra knob.
One question for FIPS_SIGNATURE_SELFTEST is enough.
Just to clarify, you'd like to see FIPS_SIGNATURE_SELFTEST_RSA
automatically set based on the values in FIPS_SIGNATURE_SELFTEST,
CRYPTO_RSA, etc.?
Oh and please cc Jarkko Sakkinen <jarkko@xxxxxxxxxx> since he
picked up two earlier fixes for this and it's best if this went
through his tree.
Will do, thanks.
Thanks,
