Re: [PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes
From: "Jarkko Sakkinen" <jarkko@xxxxxxxxxx>
Date: Fri, 10 May 2024 11:08:42 +0300
Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <lukas@xxxxxxxxx>
In-reply-to: <20240510015921.179175-1-stefanb@linux.ibm.com>
References: <20240510015921.179175-1-stefanb@linux.ibm.com>

On Fri May 10, 2024 at 4:59 AM EEST, Stefan Berger wrote:
> +		memcpy((u8 *)&msd + sizeof(msd) - o, in, o);

Not a review/NAK comment but I personally prefer to treat these
like arrays:

&((u8 *)&msd)[sizeof(msd) - o]

It is totally fine as it is.

BR, Jarkko

References:
- [PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes
  - From: Stefan Berger

Prev by Date: Re: [PATCHv3 00/19] zram: convert to custom compression API and allow algorithms tuning
Next by Date: Re: [PATCHv3 00/19] zram: convert to custom compression API and allow algorithms tuning
Previous by thread: [PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes
Next by thread: Re: [PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]

Powered by Linux