Hi Krzysztof, On Wed, Apr 17, 2024 at 6:02 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > Usually we do not recommend hiding code behind !CONFIG_OF because this > limits possible usage on ACPI systems via PRP0001. Not sure if it is > applicable here, because there is already ACPI matching. > > I would suggest choose whatever makes code simpler... Or just mark some > pieces with __maybe_unused if they are really not used? That would avoid > ifdeffery. Interesting about PRP0001. Alright. It looks like I can't quite do without ifdefs because the code dereferences ->handle in a acpi_device struct, but I can minimize it all to just a single ifdef. Jason
