Re: [PATCH] crypto: ecc: remove checks in crypto_ecdh_shared_secret() and ecc_make_pub_key()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 01, 2024 at 03:16:23PM +0300, Roman Smirnov wrote:
> With the current state of the code, ecc_get_curve() cannot return
> NULL in crypto_ecdh_shared_secret() and ecc_make_pub_key(). This is
> conditioned by the fact that they are only called from ecdh_compute_value(),
> which implements the kpp_alg::{generate_public_key,compute_shared_secret}()
> methods. Also ecdh implements the kpp_alg::init() method, which is called
> before the other methods and sets ecdh_ctx::curve_id to a valid value.
> 
> Signed-off-by: Roman Smirnov <r.smirnov@xxxxxx>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> ---
>  crypto/ecc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux