On Thu, Apr 11, 2024 at 11:51:56PM +0000, Hailey Mothershead wrote: > > @@ -111,7 +113,7 @@ static int ecdh_compute_value(struct kpp_request *req) > free_all: > kfree_sensitive(shared_secret); > free_pubkey: > - kfree(public_key); > + kfree_sensitive(public_key); It makes no sense to zero the public key. Nack. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt