On 3/29/24 23:58, Michael Roth wrote:
+ memslot = gfn_to_memslot(kvm, params.gfn_start);
+ if (!kvm_slot_can_be_private(memslot)) {
+ ret = -EINVAL;
+ goto out;
+ }
+
This can be moved to kvm_gmem_populate.
+ populate_args.src = u64_to_user_ptr(params.uaddr);
This is not used if !do_memcpy, and in fact src is redundant with
do_memcpy. Overall the arguments can be "kvm, gfn, src, npages,
post_populate, opaque" which are relatively few and do not need the struct.
I'll do that when posting the next version of the patches in kvm-coco-queue.
Paolo
