Hello, On Tue, Mar 26, 2024 at 06:04:46PM +0000, Conor Dooley wrote: > On Tue, Mar 26, 2024 at 06:32:15PM +0300, Alexey Romanov wrote: > > Now crypto module available at G12A/G12B/S4/A1/SM1/AXG. > > > > 1. Add new compatibles: > > - amlogic,g12a-crypto > > - amlogic,axg-crypto > > - amlogic,a1-crypto > > - amlogic,s4-crypto (uses a1-crypto as fallback) > > > > 2. Add power-domains in schema. > > > > Signed-off-by: Alexey Romanov <avromanov@xxxxxxxxxxxxxxxxx> > > --- > > .../bindings/crypto/amlogic,gxl-crypto.yaml | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > index d3af7b4d5f39..c92edde314aa 100644 > > --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > @@ -11,8 +11,16 @@ maintainers: > > > > properties: > > compatible: > > - items: > > - - const: amlogic,gxl-crypto > > + oneOf: > > + - items: > > + - enum: > > + - amlogic,s4-crypto > > + - const: amlogic,a1-crypto > > + - enum: > > + - amlogic,gxl-crypto > > + - amlogic,axg-crypto > > + - amlogic,g12a-crypto > > + - amlogic,a1-crypto > > > > reg: > > maxItems: 1 > > @@ -21,6 +29,9 @@ properties: > > items: > > - description: Interrupt for flow 0 > > > > + power-domains: > > + maxItems: 1 > > Is power-domains valid for the devices that existed prior to your patch? For existed devices (GXL) power domain doesn't required. -- Thank you, Alexey
