On Sun, Mar 24, 2024 at 05:12:26PM +0100, Uwe Kleine-König wrote: > There are considerations to drop platform_driver_probe() as a concept > that isn't relevant any more today. It comes with an added complexity > that makes many users hold it wrong. (E.g. this driver should have mark > the driver struct with __refdata.) > > Convert the driver to the more usual module_platform_driver(). > > This fixes a W=1 build warning: > > WARNING: modpost: drivers/char/hw_random/mxc-rnga: section mismatch in reference: mxc_rnga_driver+0x10 (section: .data) -> mxc_rnga_remove (section: .exit.text) > > with CONFIG_HW_RANDOM_MXC_RNGA=m. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Hello, > > while I indeed fixed the mentioned warning in (implicit) v1, I > introduced another one because I failed to drop __init from > mxc_rnga_probe. :-\ > > This is fixed here. > > Best regards > Uwe > > drivers/char/hw_random/mxc-rnga.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
