On Thu Mar 21, 2024 at 7:42 PM EET, Stefan Berger wrote:
>
>
> On 3/21/24 13:17, Jarkko Sakkinen wrote:
> > On Wed Mar 20, 2024 at 1:47 PM EET, Stefan Berger wrote:
> >> Add the number of bits a curve has to the ecc_curve definition to be able
> >> to derive the number of bytes a curve requires for its coordinates from it.
> >> It also allows one to identify a curve by its particular size. Set the
> >> number of bits on all curve definitions.
> >>
> >> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> >> Tested-by: Lukas Wunner <lukas@xxxxxxxxx>
> >> ---
>
> >> .y = tc512b_g_y,
> >> diff --git a/include/crypto/ecc_curve.h b/include/crypto/ecc_curve.h
> >> index 70964781eb68..63d5754e7614 100644
> >> --- a/include/crypto/ecc_curve.h
> >> +++ b/include/crypto/ecc_curve.h
> >> @@ -23,6 +23,7 @@ struct ecc_point {
> >> * struct ecc_curve - definition of elliptic curve
> >> *
> >> * @name: Short name of the curve.
> >> + * @nbits: The number of bits of a curve.
> >> * @g: Generator point of the curve.
> >> * @p: Prime number, if Barrett's reduction is used for this curve
> >> * pre-calculated value 'mu' is appended to the @p after ndigits.
> >> @@ -34,6 +35,7 @@ struct ecc_point {
> >> */
> >> struct ecc_curve {
> >> char *name;
> >> + unsigned int nbits;
> >
> > Nit:
> >
> > Hmm not strongly opionated here but wouldn't it be more consistent to
> > use u32 here as the types below are also exact bitsize types?
>
> I will change this for v8. I will probably delay v8 until this patch
> here has been queued for upstreaming because 11/13 will need a similar
> module alias.
>
> https://lore.kernel.org/linux-crypto/20240321144433.1671394-1-stefanb@xxxxxxxxxxxxx/T/#u
Right for this:
Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
... given that I don't have strong opinion on the choice :-)
BR, Jarkko
