WangYuli <wangyuli@xxxxxxxxxxxxx> wrote: > The LoongArch CRC32 hw acceleration is based on > arch/mips/crypto/crc32-mips.c. While the MIPS code supports both > MIPS32 and MIPS64, LA32 lacks the CRC instruction. As a result, > "line len -= sizeof(u32)" is unnecessary. > > Removing it can make context code style more unified and improve > code readability. > > Suggested-by: Guan Wentao <guanwentao@xxxxxxxxxxxxx> > Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx> > --- > arch/loongarch/crypto/crc32-loongarch.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/loongarch/crypto/crc32-loongarch.c b/arch/loongarch/crypto/crc32-loongarch.c > index a49e507af38c..3eebea3a7b47 100644 > --- a/arch/loongarch/crypto/crc32-loongarch.c > +++ b/arch/loongarch/crypto/crc32-loongarch.c > @@ -44,7 +44,6 @@ static u32 crc32_loongarch_hw(u32 crc_, const u8 *p, unsigned int len) > > CRC32(crc, value, w); > p += sizeof(u32); > - len -= sizeof(u32); > } This makes no sense whatsoever. Please review this patch carefully before you resubmit. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
