Sure Eric, I will remove them from the driver, clean up all the build errors and submit v1 of this patchset. - PK On Wed, Mar 6, 2024 at 9:30 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > On Wed, Mar 06, 2024 at 09:16:31AM +0530, Pavitrakumar Managutte wrote: > > > Algorithms that don't have a generic implementation shouldn't be included. > > > > > Hi Eric, > > Yes we have tested this with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y > > > > Also is it fine if those additional algos stay inside that disabled > > CONFIG. SPAcc hardware > > does support those algos. > > > > - PK > > > > If you provide an option to build them into the driver, that still counts as > them being there. I think they should just be left out entirely for now. > > - Eric
