On Tue, Feb 20, 2024 at 04:10:39PM +0100, Lukas Wunner wrote: > > In x509_cert_parse(), add a hint for the compiler that kzalloc() never > returns an ERR_PTR(). Otherwise the compiler adds a gratuitous IS_ERR() > check on return. Introduce a handy assume() macro for this which can be > re-used elsewhere in the kernel to provide hints for the compiler. Would it be possible to move the use of assume into the kzalloc declaration instead? Perhaps by turning it into a static inline wrapper that does the "assume"? Otherwise as time goes on we'll have a proliferation of these "assume"s all over the place. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt