Re: [PATCH] loongarch/crypto: Clean up useless assignment operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Okay, somehow i think Yuli the origin commit message some misleading
things,the whole story expand that origin mips/crypto/crc32-mips.c code 
"len -= sizeof(u32);" necessary only in "!CONFIG_64BIT" macro define,
they are just a "binary bit" game as we tran the number to binary bit,
while less and less one in 64bit ,the less thing we do if >=32bit do once,
>=16bit do once ... etc... If we delete the useless code line, it is very cool,
and unrelated to specific ISA. We also think maybe we need to add 
"#ifnef CONFIG_64BIT"in origin mips/crypto/crc32-mips.c "len -= sizeof(u32);",
but it add code instead of delete code...

Thanks.
Guan Wentao




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux