On Thu, Feb 15, 2024 at 02:47:07PM +0800, Herbert Xu wrote: > On Wed, Feb 14, 2024 at 02:56:38PM -0800, Eric Biggers wrote: > > > > Shouldn't they still be supported if the data is being read/written all at once? > > It is supported, or at least it worked for my libkcapi tests on > adiantum. This error only triggers if we enter the code-path that > splits the operation into two or more (because the user didn't > write all the data in one go). Great, that isn't what the commit message says though. > > > Also, ENOSYS isn't really an appropriate error code. ENOSYS normally means that > > the system call isn't supported at all. Maybe use EOPNOTSUPP? > > Within the crypto subsystem ENOSYS means that a particular > functionality is not supported. I'm happy to change that but > that should go into a different patch as there are existing uses > which are similar (e.g., cloning). This is a user API; it's not "within the crypto subsystem". The usual conventions for system calls apply. - Eric
