On Fri, Feb 09, 2024 at 01:42:07PM +0100, Damian Muszynski wrote:
> The implementation of the Rate Limiting (RL) feature includes the cleanup
> of all SLAs during device shutdown. For each SLA, the firmware is notified
> of the removal through an admin message, the data structures that take
> into account the budgets are updated and the memory is freed.
> However, this explicit cleanup is not necessary as (1) the device is
> reset, and the firmware state is lost and (2) all RL data structures
> are freed anyway.
>
> In addition, if the device is unresponsive, for example after a PCI
> AER error is detected, the admin interface might not be available.
> This might slow down the shutdown sequence and cause a timeout in
> the recovery flows which in turn makes the driver believe that the
> device is not recoverable.
>
> Fix by replacing the explicit SLAs removal with just a free of the
> SLA data structures.
>
> Fixes: d9fb8408376e ("crypto: qat - add rate limiting feature to qat_4xxx")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Damian Muszynski <damian.muszynski@xxxxxxxxx>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>
> ---
> drivers/crypto/intel/qat/qat_common/adf_rl.c | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
