On Wed, Feb 7, 2024 at 2:55 PM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:
>
> When the PSP_CMDRESP_STS field has an error set, the details of the
> error are in `req->header->status`, and the caller will want to look
> at them. But if there is no error set then caller may want to check
> `req->header->status` separately.
>
> Stop discarding these errors.
>
> Reported-by: Tim Van Patten <timvp@xxxxxxxxxx>
> Fixes: 7ccc4f4e2e50 ("crypto: ccp - Add support for an interface for platform features")
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> drivers/crypto/ccp/platform-access.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/platform-access.c b/drivers/crypto/ccp/platform-access.c
> index 94367bc49e35..792ae8d5b11a 100644
> --- a/drivers/crypto/ccp/platform-access.c
> +++ b/drivers/crypto/ccp/platform-access.c
> @@ -120,7 +120,8 @@ int psp_send_platform_access_msg(enum psp_platform_access_msg msg,
>
> /* Store the status in request header for caller to investigate */
> cmd_reg = ioread32(cmd);
> - req->header.status = FIELD_GET(PSP_CMDRESP_STS, cmd_reg);
> + if (FIELD_GET(PSP_CMDRESP_STS, cmd_reg))
> + req->header.status = FIELD_GET(PSP_CMDRESP_STS, cmd_reg);
> if (req->header.status) {
> ret = -EIO;
> goto unlock;
> --
> 2.34.1
>
Tested-by: Tim Van Patten <timvp@xxxxxxxxxx>
