Hi Herbert, What are your plans for this change? Thanks, Meenakshi > -----Original Message----- > From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Sent: Thursday, July 6, 2023 3:28 AM > To: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx> > Cc: Eric Biggers <ebiggers@xxxxxxxxxx>; agk@xxxxxxxxxx; snitzer@xxxxxxxxxx; > linux-crypto@xxxxxxxxxxxxxxx; dm-devel@xxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; qat-linux@xxxxxxxxx; heinzm@xxxxxxxxxx; Meenakshi > Aggarwal <meenakshi.aggarwal@xxxxxxx>; Horia Geanta > <horia.geanta@xxxxxxx>; Varun Sethi <V.Sethi@xxxxxxx>; Pankaj Gupta > <pankaj.gupta@xxxxxxx>; Gaurav Jain <gaurav.jain@xxxxxxx>; > davem@xxxxxxxxxxxxx; Iuliana Prodan <iuliana.prodan@xxxxxxx>; Fiona Trahe > <fiona.trahe@xxxxxxxxx> > Subject: Re: [PATCH 1/3] dm integrity: do not filter algos with > CRYPTO_ALG_ALLOCATES_MEMORY > > On Wed, Jul 05, 2023 at 09:57:54PM +0100, Giovanni Cabiddu wrote: > > > > Then we are then back to square one. We need to check how many entries > > are present in the scatterlists encrypted by crypt_journal() before > > adjusting the meaning of !CRYPTO_ALG_ALLOCATES_MEMORY. > > Indeed. I missed the fact that it was preallocating memory with GFP_KERNEL. > > So perhaps the answer is to adjust our API to allow the drivers to pre-allocate > memory. I'll look into this. > > Thanks, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: > http://gondor.ap/ > ana.org.au%2F~herbert%2F&data=05%7C01%7Cmeenakshi.aggarwal%40nxp.co > m%7C59d63c0b42d5423abb1108db7da2e431%7C686ea1d3bc2b4c6fa92cd99c5 > c301635%7C0%7C0%7C638241910806938399%7CUnknown%7CTWFpbGZsb3d8 > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > 7C3000%7C%7C%7C&sdata=vdLCyhQOSTEhIK1%2FkAO7Z%2Fu6ejrLbRHwM88N > DmsqaP0%3D&reserved=0 > PGP Key: > http://gondor.ap/ > ana.org.au%2F~herbert%2Fpubkey.txt&data=05%7C01%7Cmeenakshi.aggarwal > %40nxp.com%7C59d63c0b42d5423abb1108db7da2e431%7C686ea1d3bc2b4c6f > a92cd99c5c301635%7C0%7C0%7C638241910806938399%7CUnknown%7CTWF > pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 > Mn0%3D%7C3000%7C%7C%7C&sdata=eAkggsD8FaJzb9OO2p1bcaPYs8xt47Eav > UdVVssGM7o%3D&reserved=0