On 2024/1/31 23:33, Dave Hansen wrote:
[这封邮件来自外部发件人 谨防风险]
On 1/31/24 01:45, Tony W Wang-oc wrote:
static const struct x86_cpu_id padlock_sha_ids[] = {
- X86_MATCH_FEATURE(X86_FEATURE_PHE, NULL),
+ X86_MATCH_VENDOR_FAM_FEATURE(CENTAUR, 6, X86_FEATURE_PHE, NULL),
{}
};
Logically, this is saying that there are non-CENTAUR or non-family-6
CPUs that set X86_FEATURE_PHE, but don't support X86_FEATURE_PHE. Is
that the case?
Not exactly.
Zhaoxin CPU supports X86_FEATURE_PHE and X86_FEATURE_PHE2.
We expect the Zhaoxin CPU to use the zhaoxin_sha driver introduced in
the third patch of this patch set.
Without this patch Zhaoxin CPU will also match the padlock-sha driver too.
I honestly have no idea what this is saying.
Could you try again, please?
Sorry. It should be said that there are non-CENTAUR or non-family-6 CPUs
that set X86_FEATURE_PHE,
and also set the new X86_FEATURE_PHE2. For these CPUs, we expect to use
a new driver that supports
both X86_FEATURE_PHE and X86_FEATURE_PHE2.
So we make the driver padlock-sha to matches CENTAUR Family-6 CPU
explicitly.
