On Thu Jan 18, 2024 at 12:07 PM UTC, Colin Ian King wrote: > The pointer secs is being assigned a value however secs is never > read afterwards. The pointer secs is redundant and can be removed. > > Cleans up clang scan build warning: > warning: Although the value stored to 'secs' is used in the enclosing > expression, the value is never actually read from 'secs' > [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > --- > crypto/asymmetric_keys/verify_pefile.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c > index f440767bd727..2863984b6700 100644 > --- a/crypto/asymmetric_keys/verify_pefile.c > +++ b/crypto/asymmetric_keys/verify_pefile.c > @@ -28,7 +28,7 @@ static int pefile_parse_binary(const void *pebuf, unsigned int pelen, > const struct pe32plus_opt_hdr *pe64; > const struct data_directory *ddir; > const struct data_dirent *dde; > - const struct section_header *secs, *sec; > + const struct section_header *sec; > size_t cursor, datalen = pelen; > > kenter(""); > @@ -110,7 +110,7 @@ static int pefile_parse_binary(const void *pebuf, unsigned int pelen, > ctx->n_sections = pe->sections; > if (ctx->n_sections > (ctx->header_size - cursor) / sizeof(*sec)) > return -ELIBBAD; > - ctx->secs = secs = pebuf + cursor; > + ctx->secs = pebuf + cursor; > > return 0; > } Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> BR, Jarkko