On Wed, 2023-12-13 at 11:01 +0800, Wang Jinchao wrote: > On Tue, Dec 12, 2023 at 01:56:56PM -0800, Tim Chen wrote: > > On Sun, 2023-12-10 at 18:19 +0800, WangJinchao wrote: > > > Create a script for comparing tcrypt speed test logs. > > > The script will systematically analyze differences item > > > by item and provide a summary (average). > > > This tool is useful for evaluating the stability of > > > cryptographic module algorithms and assisting with > > > performance optimization. > > > > I have found that for such comparison, the stability is > > dependent on whether we allow the frequency to > > float or we pin the frequency. So in the past when > > I use tcrypt, sometimes I have > > to pin the frequency of CPU for stable results. > > > > One suggestion I have is for for you to also dump the > > frequency governor and P-state info so we know > > for the runs being compared, whether they are running > > with the same CPU frequency. > > > > Tim > > > Thank you for the feedback. This information is valuable for stability testing > and performance optimization. > > However, I am uncertain about how to dump P-state information, or I believe that > the script is unable to do so. The reasons are as follows: > > 1. The primary purpose of this script is to compare tcrypt logs, and it is > executed after the completion of the tcrypt tests. Consequently, it cannot > dump P-state information during tcrypt's runtime. > > 2. In virtualized environments, there is no available information in the > `/sys/devices/system/cpu/cpufreq` directory pertaining to P-state details. > > Am I correct in my understanding? > I am considering documenting your suggestion in the script's comments. > What are your thoughts? > > I think that will be fine. Thanks. Tim