> -----Original Message----- > From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, December 8, 2023 11:28 AM > To: Gonglei (Arei) <arei.gonglei@xxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx; Michael S. Tsirkin <mst@xxxxxxxxxx>; Jason > Wang <jasowang@xxxxxxxxxx>; virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; wangyangxin <wangyangxin1@xxxxxxxxxx>; > Halil Pasic <pasic@xxxxxxxxxxxxx> > Subject: Re: [PATCH v2] crypto: virtio-crypto: Handle dataq logic with tasklet > > On Wed, Dec 06, 2023 at 11:52:51AM +0000, Gonglei (Arei) wrote: > > Doing ipsec produces a spinlock recursion warning. > > This is due to crypto_finalize_request() being called in the upper half. > > Move virtual data queue processing of virtio-crypto driver to tasklet. > > > > Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver") > > Reported-by: Halil Pasic <pasic@xxxxxxxxxxxxx> > > Signed-off-by: wangyangxin <wangyangxin1@xxxxxxxxxx> > > Signed-off-by: Gonglei <arei.gonglei@xxxxxxxxxx> > > --- > > v2: calling tasklet_kill() in virtcrypto_remove(), thanks for MST. > > > > drivers/crypto/virtio/virtio_crypto_common.h | 2 ++ > > drivers/crypto/virtio/virtio_crypto_core.c | 26 > ++++++++++++++++---------- > > 2 files changed, 18 insertions(+), 10 deletions(-) > > Your patch has already been merged. So please send this as an incremental > patch. > OK. No problem. Regards, -Gonglei > Thanks, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: > http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
