On 02.12.2023 03:52, Herbert Xu wrote:
On Fri, Dec 01, 2023 at 05:06:03PM -0800, Vadim Fedorenko wrote:+static int bpf_crypto_lskcipher_encrypt(void *tfm, const u8 *src, u8 *dst, + unsigned int len, u8 *iv) +{ + return crypto_lskcipher_encrypt(tfm, src, dst, len, iv); +}Please note that the API has been updated and the iv field is now the siv. For algorithms with a non-zero statesize, that means that the IV must be followed by enough memory to store the internal state, i.e., crypto_lskcipher_statesize(tfm). Thanks,
Hi Herbert! Thanks for the reminder. I have read v3 of your patchset and AFAIU only arc4 is affected right now. All other algorithms still have statesize=0, so should work without any changes. I'll make a TODO note for myself to add state size check in bpf_crypto part once different trees are merged during merge window. Am I right that it only affects skcipher and AEAD crypto will not be changed? Thanks, Vadim
