On Fri, Nov 17, 2023 at 05:07:22PM +0800, Herbert Xu wrote: > On Thu, Nov 16, 2023 at 09:42:31PM -0800, Eric Biggers wrote: > . > > crypto_lskcipher_crypt_sg() assumes that a single en/decryption operation can be > > broken up into multiple ones. I think you're arguing that since there's no OK I see where some of the confusion is coming from. The current skcipher interface assumes that the underlying algorithm can be chained. So the implementation of chacha is actually wrong as it stands and it will produce incorrect results when used through if_alg. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
