Re: [PATCH 1/4] Add SPACC driver to Linux kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 14, 2023 at 10:35:22AM +0530, Pavitrakumar M wrote:
>
> +	/* Below algorithms are not supported in crypto test manager */
> +	{ MODE_TAB_HASH("mac(kasumi)", MAC_KASUMI_F9, 4, 64), .sw_fb = false },

Please do not add algorithms where there are no generic implementations.

> +static int spacc_hash_import(struct ahash_request *req, const void *in)
> +{
> +	struct spacc_crypto_reqctx *ctx = ahash_request_ctx(req);
> +
> +	memcpy(ctx, in, sizeof(*ctx));
> +
> +	return 0;
> +}

The import/export functions are meant to serialise the hash state
so that they can be continued later.  Did you run the self-tests
with extra fuzz tests enabled?

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux