Re: [PATCH] nvme-auth: use crypto_shash_tfm_digest()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] nvme-auth: use crypto_shash_tfm_digest()
From: Sagi Grimberg <sagi@xxxxxxxxxxx>
Date: Mon, 20 Nov 2023 15:51:48 +0200
Cc: Keith Busch <kbusch@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx
In-reply-to: <20231030132816.GC21741@lst.de>
References: <20231029050040.154563-1-ebiggers@kernel.org> <20231030132816.GC21741@lst.de>
User-agent: Mozilla Thunderbird

From: Eric Biggers <ebiggers@xxxxxxxxxx>

Simplify nvme_auth_augmented_challenge() by using
crypto_shash_tfm_digest() instead of an alloc+init+update+final
sequence.  This should also improve performance.


Nice:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>


Indeed. fwiw:
Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx>

References:
- [PATCH] nvme-auth: use crypto_shash_tfm_digest()
  - From: Eric Biggers
- Re: [PATCH] nvme-auth: use crypto_shash_tfm_digest()
  - From: Christoph Hellwig

Prev by Date: Re: Aw: [PATCH 6/6] crypto: rockchip: add rk3588 driver
Next by Date: [PATCH] hwrng: starfive - Fix dev_err_probe return error
Previous by thread: Re: [PATCH] nvme-auth: use crypto_shash_tfm_digest()
Next by thread: Re: [PATCH] nvme-auth: use crypto_shash_tfm_digest()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]

Powered by Linux