On 2023-11-16 15:42, Krzysztof Kozlowski wrote:
+properties:
+ compatible:
+ oneOf:
+ - const: inside-secure,safexcel-eip197b
+ - const: inside-secure,safexcel-eip197d
+ - const: inside-secure,safexcel-eip97ies
+ - const: inside-secure,safexcel-eip197
+ description: Equivalent of inside-secure,safexcel-eip197b
+ deprecated: true
+ - const: inside-secure,safexcel-eip97
+ description: Equivalent of inside-secure,safexcel-eip97ies
+ deprecated: true
Wait, some new entries appear here and commit msg said nothing about
changes in the binding. Commit says it is pure conversion. You must
document all changes made.
I may make many mistakes but not one like that. I am phobic to adding
new stuff silently. All those entries were documented in .txt.
+allOf:
+ - if:
+ properties:
+ clocks:
+ minItems: 2
+ then:
+ required:
+ - clock-names
Did you test that it actually works? Considering other patchset which
you did not, I have doubts that this was...
Sorry, I really have bad experience with Python due its maze of
dependencies and unfriendly feedback. I just wasted half an hour
debugging error like:
Traceback (most recent call last):
File "/home/rmilecki/.local/bin/dt-doc-validate", line 64, in <module>
ret |= check_doc(f)
File "/home/rmilecki/.local/bin/dt-doc-validate", line 32, in
check_doc
for error in sorted(dtsch.iter_errors(), key=lambda e: e.linecol):
File
"/home/rmilecki/.local/lib/python3.10/site-packages/dtschema/schema.py",
line 132, in iter_errors
self.annotate_error(scherr, meta_schema, scherr.schema_path)
File
"/home/rmilecki/.local/lib/python3.10/site-packages/dtschema/schema.py",
line 111, in annotate_error
schema = schema[p]
KeyError: 'type'
which turned out to be a result of some outdated examples files.
I tested that binding thought. Still after another look at that allOf I
found one more corner case to cover.
--
Rafał Miłecki
