On Wed, Nov 01, 2023 at 10:40:08PM -0700, Eric Biggers wrote: > > Do you have in mind making struct ahash_request specify the data by either > scatterlist or by virtual address? It might be possible. It would be necessary > to wire up all possible combinations of (SG, virt) x (ahash_alg, shash_alg), > with the vmalloc_to_page() hack for the virt + ahash_alg case. Yes that's what I had in mind. We need to do something similar for akcipher now that the top-level interface is linear only but the drivers are still SG-based. > Well, struct shash_desc used to have that flag, but it never did anything. The > few use cases like this might be more simply served by just having a helper > function crypto_shash_update_large() that passes the data in chunks to > crypto_shash_update(). Are you volunteering to add this interface? :) The module signature path is really broken right now, at least on non-preemptible kernels. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
