On Wed, Nov 01, 2023 at 09:20:43PM -0700, Eric Biggers wrote: > > Updating all callers of skcipher_walk_virt() seems like the wrong approach. > Shouldn't skcipher_walk_virt() be fixed to initialize the flags to 0 instead? The bits of the flags that are used are initialised in skcipher_walk_next. > Also, does this fix affect any behavior, or is it just to fix a KMSAN warning? > It needs to be fixed either way, but it's helpful to understand the effect of > the fix so that people can decide whether it needs to be backported or not. Does this actually trigger a KMSAN warning? If so I'd like to see it. If it's just a static analyser then I'm not applying this. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
