Re: [PATCH] crypto: qat - add heartbeat error simulator

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Fri, Oct 20, 2023 at 04:55:26PM +0100, Shashank Gupta wrote:
>
> +#ifdef QAT_HB_ERROR_INJECTION

Please move this into the code.

> +#ifdef QAT_HB_ERROR_INJECTION
> +	hb->dbgfs.inject_error = debugfs_create_file("inject_error", 0200,
> +						     hb->dbgfs.base_dir, accel_dev,
> +						     &adf_hb_error_inject_fops);
> +#endif

So this would look like

	if (IS_ENABLED(CONFIG_CRYPTO_DEV_QAT_ERROR_INJECTION)) {
		struct dentry *inject_error __maybe_unused;

		inject_error = debugfs_create_file("inject_error", 0200,
						   hb->dbgfs.base_dir, accel_dev,
						   &adf_hb_error_inject_fops);
#ifdef CONFIG_CRYPTO_DEV_QAT_HB_ERROR_INJECTION
		hb->dbgfs.inject_error = inject_error;
#endif
	}

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt