On Mon, Oct 09, 2023 at 09:20:52PM +0000, Alexander Graf wrote: > To fully support the Nitro Secure Module communication protocol, we need > to encode and decode CBOR binary data. Import an MIT licensed library > from https://github.com/libmcu/cbor (commit f3d1696f886) so that we can > easily consume CBOR data. What is "CBOR"? I don't see a description of it here. And I guess you are going to keep this in sync with upstream? Or do you really need the full library here (you #ifdef the float stuff out), does your module really need all of the functionality and complexity of this library, or can it use just a much smaller one instead? > On top of the upstream code base, I added kernel module as well as > kernel header path awareness and made checkpatch happy. If only the one module needs this, why not put it in the directory for the module itself, and then when/if anyone else needs it, it could be moved? thanks, greg k-h
