On Wed, Oct 04, 2023 at 03:07:10PM -0400, Daniel Jordan wrote: > On Wed, Oct 04, 2023 at 10:54:29AM -0400, Daniel Jordan wrote: > > On Thu, Sep 28, 2023 at 08:38:53AM +0800, Wang Jinchao wrote: ... > > This could use a Fixes tag. From Nicolai's patch[0] we agreed on > > > > Fixes: 07928d9bfc81 ("padata: Remove broken queue flushing") > > > > With that, > > > > Acked-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> > > > > Thanks! > > ... > > Oh, I should've also said please move the declaration of pd to the top > of the function like scripts/checkpatch.pl suggests. > > > > + if (refcount_dec_and_test(&pd->refcnt)) > > > + padata_free_pd(pd); > > > mutex_unlock(&ps->pinst->lock); > > > > > > kfree(ps); > > > -- > > > 2.40.0 > > > Thanks for suggestion, both were updated in V3. V3: https://lore.kernel.org/all/ZSDWAcUxXcwD4YUZ@fedora/