Lukas Wunner wrote: > Currently only a single default signature encoding is supported per > akcipher. > > A subsequent commit will allow a second encoding for ecdsa, namely P1363 > alternatively to X9.62. > > To accommodate for that, amend struct akcipher_request and struct > crypto_akcipher_sync_data to store the desired signature encoding for > verify and sign ops. > > Amend akcipher_request_set_crypt(), crypto_sig_verify() and > crypto_sig_sign() with an additional parameter which specifies the > desired signature encoding. Adjust all callers. > > Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx> > --- > crypto/akcipher.c | 2 +- > crypto/asymmetric_keys/public_key.c | 4 ++-- > crypto/internal.h | 1 + > crypto/rsa-pkcs1pad.c | 11 +++++++---- > crypto/sig.c | 6 ++++-- > crypto/testmgr.c | 8 +++++--- > crypto/testmgr.h | 1 + > include/crypto/akcipher.h | 10 +++++++++- > include/crypto/sig.h | 6 ++++-- > 9 files changed, 34 insertions(+), 15 deletions(-) I can only review this in generic terms, I just wonder why this decided to pass a string rather than an enum?
