Hi Herbert, On Fri, 15 Sept 2023 at 12:46, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, Sep 10, 2023 at 10:34:17AM +0200, Jonas Gorski wrote: > > When the membase and pci_dev pointer were moved to a new struct in priv, > > the actual membase users were left untouched, and they started reading > > out arbitrary memory behind the struct instead of registers. This > > unfortunately turned the RNG into a constant number generator, depending > > on the content of what was at that offset. > > > > To fix this, update geode_rng_data_{read,present}() to also get the > > membase via amd_geode_priv, and properly read from the right addresses > > again. > > > > Fixes: 9f6ec8dc574e ("hwrng: geode - Fix PCI device refcount leak") > > Reported-by: Timur I. Davletshin <timur.davletshin@xxxxxxxxx> > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217882 > > Tested-by: Timur I. Davletshin <timur.davletshin@xxxxxxxxx> > > Suggested-by: Jo-Philipp Wich <jo@xxxxxxx> > > Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx> > > --- > > drivers/char/hw_random/geode-rng.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > Patch applied. Thanks. Where was it applied? I don't see it neither in linus' tree nor in char-misc. Wondering if it got stuck somewhere. Best Regards, Jonas