On Sun, Oct 01, 2023 at 04:18:50PM +0800, Herbert Xu wrote: > On Fri, Sep 22, 2023 at 12:15:27PM +0200, Lucas Segarra Fernandez wrote: > > > > diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c > > new file mode 100644 > > index 000000000000..55db62a46497 > > --- /dev/null > > +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c > > @@ -0,0 +1,255 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* Copyright(c) 2023 Intel Corporation */ > > +#include <linux/bits.h> > > +#include <linux/dma-mapping.h> > > +#include <linux/slab.h> > > +#include <linux/stddef.h> > > +#include <linux/string_helpers.h> > > +#include <linux/stringify.h> > > +#include <linux/types.h> > > The kernel.h comment applies to this patch too. > > Thanks, Will be resubmitted including kernel.h in this file. For the last 2 submitted versions of this patchset we've tried to apply the Rule of Thumb mentioned in [1], understood as: Include kernel.h in every .C file that includes __3 or more__ headers directly included by kernel.h, otherwise include the directly used headers. It seems this understanding is not correct. Could you help to understand which is the Good Practice in this regard? Should kernel.h be included in __every__ new C file a patch adds? Thank you! [1] https://lore.kernel.org/lkml/ZPAPSOnSTMgYrlV%2F@xxxxxxxxxxxxxxxxxxx/
