On Fri, Sep 22, 2023 at 08:15:27AM +0000, Alexey Romanov wrote: > > Are you suggesting remove meson_rng_priv and putting a pointer to read > function in meson_rng_data? I just thought it was weird that you assign meson_rng_data->priv and then never use it anywhere else in the driver. Did I miss something? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt