On Fri, Aug 25, 2023 at 06:39:36PM +0800, Herbert Xu wrote: > On Fri, Aug 18, 2023 at 12:23:09PM +0200, Lucas Segarra Fernandez wrote: > > #include <linux/bitfield.h> > > +#include <linux/bits.h> > > This is redundant if you include linux/kernel. Why?! Can we avoid using kernel.h, please? > > +#include <linux/dma-mapping.h> > > +#include <linux/fs.h> > > #include <linux/iopoll.h> > > #include <linux/kstrtox.h> > > +#include <linux/slab.h> > > +#include <linux/stddef.h> > > So is this. Ditto. -- With Best Regards, Andy Shevchenko