On Fri, Aug 25, 2023 at 06:41:18PM +0800, Herbert Xu wrote: > > No need to resubmit. I will fix this up when I apply these two > patches. I take that back. This doesn't even build with CONFIG_DEBUG_FS=n. ../drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c: In function ‘adf_gen4_init_dev_pm_data’: ../drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c:403:55: error: ‘adf_gen4_print_pm_status’ undeclared (first use in this function) 403 | accel_dev->power_management.print_pm_status = adf_gen4_print_pm_status; | ^~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c:403:55: note: each undeclared identifier is reported only once for each function it appears in make[8]: *** [../scripts/Makefile.build:243: drivers/crypto/intel/qat/qat_common/adf_gen4_pm.o] Error 1 Please resubmit after you fix that and include kernel.h while you're at it. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt