Thanks for the comments, Kevin.
> -----Original Message-----
> From: Tian, Kevin <kevin.tian@xxxxxxxxx>
> Sent: Friday, August 4, 2023 3:53 PM
> To: Zeng, Xin <xin.zeng@xxxxxxxxx>; linux-crypto@xxxxxxxxxxxxxxx;
> kvm@xxxxxxxxxxxxxxx
> Cc: Cabiddu, Giovanni <giovanni.cabiddu@xxxxxxxxx>;
> andriy.shevchenko@xxxxxxxxxxxxxxx; Zeng, Xin <xin.zeng@xxxxxxxxx>; Cao,
> Yahui <yahui.cao@xxxxxxxxx>
> Subject: RE: [RFC 2/5] crypto: qat - add interface for live migration
>
> > From: Xin Zeng <xin.zeng@xxxxxxxxx>
> > Sent: Friday, June 30, 2023 9:13 PM
> > +
> > +int qat_vfmig_suspend_device(struct pci_dev *pdev, u32 vf_nr)
> > +{
> > + struct adf_accel_dev *accel_dev =
> > adf_devmgr_pci_to_accel_dev(pdev);
> > +
> > + if (!accel_dev) {
> > + dev_err(&pdev->dev, "Failed to find accel_dev\n");
> > + return -ENODEV;
> > + }
> > +
> > + if (WARN_ON(!GET_VFMIG_OPS(accel_dev)->suspend_device))
> > + return -EINVAL;
>
> this and other warns should be done one-off at device registration point
> instead of letting it triggerable by every user ioctl.
Ok, will address this.
