The engine file does not need the actual crypto type definitions so move those header inclusions to where they are actually used. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> --- crypto/crypto_engine.c | 7 ++++++- include/crypto/engine.h | 17 +++++++---------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/crypto/crypto_engine.c b/crypto/crypto_engine.c index 17f7955500a0..ba43dfba2fa9 100644 --- a/crypto/crypto_engine.c +++ b/crypto/crypto_engine.c @@ -7,10 +7,15 @@ * Author: Baolin Wang <baolin.wang@xxxxxxxxxx> */ +#include <crypto/aead.h> +#include <crypto/akcipher.h> +#include <crypto/engine.h> +#include <crypto/hash.h> +#include <crypto/kpp.h> +#include <crypto/skcipher.h> #include <linux/err.h> #include <linux/delay.h> #include <linux/device.h> -#include <crypto/engine.h> #include <uapi/linux/sched/types.h> #include "internal.h" diff --git a/include/crypto/engine.h b/include/crypto/engine.h index 1b02f69e0a79..643639c3227c 100644 --- a/include/crypto/engine.h +++ b/include/crypto/engine.h @@ -7,20 +7,17 @@ #ifndef _CRYPTO_ENGINE_H #define _CRYPTO_ENGINE_H -#include <linux/crypto.h> -#include <linux/list.h> +#include <crypto/algapi.h> #include <linux/kthread.h> -#include <linux/spinlock.h> +#include <linux/spinlock_types.h> #include <linux/types.h> -#include <crypto/algapi.h> -#include <crypto/aead.h> -#include <crypto/akcipher.h> -#include <crypto/hash.h> -#include <crypto/skcipher.h> -#include <crypto/kpp.h> - +struct aead_request; +struct ahash_request; +struct akcipher_request; struct device; +struct kpp_request; +struct skcipher_request; #define ENGINE_NAME_LEN 30 /*