On 31-07-23, 16:29, Tom Zanussi wrote: > To allow idxd sub-drivers to enable and disable wqs, export them. > > Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> > Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx> > Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> > --- > drivers/dma/idxd/device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c > index 5abbcc61c528..87ad95fa3f98 100644 > --- a/drivers/dma/idxd/device.c > +++ b/drivers/dma/idxd/device.c > @@ -1505,6 +1505,7 @@ int drv_enable_wq(struct idxd_wq *wq) > err: > return rc; > } > +EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD); Sorry this is a very generic symbol, pls dont export it. I would make it idxd_drv_enable_wq() > > void drv_disable_wq(struct idxd_wq *wq) > { > @@ -1526,6 +1527,7 @@ void drv_disable_wq(struct idxd_wq *wq) > wq->type = IDXD_WQT_NONE; > wq->client_count = 0; > } > +EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD); > > int idxd_device_drv_probe(struct idxd_dev *idxd_dev) > { > -- > 2.34.1 -- ~Vinod