On 30/07/2023 20:55, Kamlesh Gurudasani wrote: > Add binding for Texas Instruments MCRC64 driver A nit, subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. Here and subject: drop driver. Bindings are for hardware. Neither commit nor bindings in description: field explain what is this hardware. > > Signed-off-by: Kamlesh Gurudasani <kamlesh@xxxxxx> > --- > Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml | 42 ++++++++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 5 +++++ > 2 files changed, 47 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml b/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml > new file mode 100644 > index 000000000000..1d1e3f87638c > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/ti,mcrc64.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments MCRC64 bindings Drop bindings. If you tested your code, you would see a warning, so: It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. > + > +maintainers: > + - Kamlesh Gurudasani <kamlesh@xxxxxx> > + > +properties: > + compatible: > + const: ti,mcrc64 What's this? Part of SoC? Then the compatible is not correct. > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + mcrc64: mcrc64@30300000 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "ti,mcrc64"; > + reg = <0x00 0x30300000 0x00 0x1000>; > + clocks = <&k3_clks 116 0>; > + power-domains = <&k3_pds 116 TI_SCI_PD_EXCLUSIVE>; > + }; Indentation is messed up. > Best regards, Krzysztof
