> -----Original Message----- > From: Horia Geanta <horia.geanta@xxxxxxx> > Sent: Monday, July 17, 2023 10:39 PM > To: Pankaj Gupta <pankaj.gupta@xxxxxxx>; Gaurav Jain > <gaurav.jain@xxxxxxx>; Varun Sethi <V.Sethi@xxxxxxx>; Herbert Xu > <herbert@xxxxxxxxxxxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; > Iuliana Prodan <iuliana.prodan@xxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx> > Subject: Re: [PATCH] caam: init-clk based on caam-page0-access > > On 7/10/2023 8:34 AM, Pankaj Gupta wrote: > > CAAM clock initialization to be done based on, soc specific info > > stored in struct caam_imx_data: > > - caam-page0-access flag > > - num_clks > > > Any specific reason for deviating from downstream implementation (based on > DT)? Implementing based on DT will lead to multiple DT entries in the same code section: - one entry for imx8ulp(fsl,imx8ulp-ele) - then for imx8dxl(fsl,imx-scu) - then for imx93 (fsl,imx93-ele) - Similar entries for future SoC as well. Hence, followed this approach. > https://github.com/nxp-imx/linux-imx/blob/lf-6.1.1- > 1.0.1/drivers/crypto/caam/ctrl.c#L911 > > Thanks, > Horia