Re: [PATCH v1] arch: s390: Use kfree_sensitive instead of kfree

[Harald Freudenberger <freude@xxxxxxxxxxxxx>]

On 2023-07-17 11:45, Wang Ming wrote:
> key might contain private part of the key, so better use
> kfree_sensitive to free it.
>
> Signed-off-by: Wang Ming <machel@xxxxxxxx>
> ---
>  arch/s390/crypto/paes_s390.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/crypto/paes_s390.c 
> b/arch/s390/crypto/paes_s390.c
> index d29a9d908797..38349150c96e 100644
> --- a/arch/s390/crypto/paes_s390.c
> +++ b/arch/s390/crypto/paes_s390.c
> @@ -103,7 +103,7 @@ static inline void _free_kb_keybuf(struct key_blob 
> *kb)
>  {
>  	if (kb->key && kb->key != kb->keybuf
>  	    && kb->keylen > sizeof(kb->keybuf)) {
> -		kfree(kb->key);
> +		kfree_sensitive(kb->key);
>  		kb->key = NULL;
>  	}
>  }

Reviewed-by: Harald Freudenberger <freude@xxxxxxxxxxxxx>