On Wed, Jun 21, 2023 at 05:06:53AM -0700, Chang S. Bae wrote: > aes_set_key_common() performs runtime alignment to the void *raw_ctx > pointer. This facilitates consistent access to the 16byte-aligned > address during key extension. > > However, the alignment is already handlded in the GCM-related setkey > functions before invoking the common function. Consequently, the > alignment in the common function is unnecessary for those functions. > > To establish a consistent approach throughout the glue code, remove > the aes_ctx() call from its current location. Instead, place it at > each call site where the runtime alignment is currently absent. > > Link: https://lore.kernel.org/lkml/20230605024623.GA4653@quark.localdomain/ > Suggested-by: Eric Biggers <ebiggers@xxxxxxxxxx> > Signed-off-by: Chang S. Bae <chang.seok.bae@xxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Cc: x86@xxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > --- > The need for this fix was discovered during Eric's review of the Key > Locker series [1]. Considering the upstream code also requires this > improvement, this is applicable regardless of the Key Locker enabling > [2]. > > [1] https://lore.kernel.org/lkml/20230605024623.GA4653@quark.localdomain/ > [2] https://lore.kernel.org/lkml/f1093780-cdda-35ec-3ef1-e5fab4139bef@xxxxxxxxx/ > --- > arch/x86/crypto/aesni-intel_glue.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
