On Fri, 30 Jun 2023 at 17:27, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Fri, 30 Jun 2023 17:16:06 +0200 Ard Biesheuvel wrote: > > Note that this is the *input* scatterlist containing the AAD > > (additional authenticated data) and the crypto input, and so there is > > definitely a bug here that shouldn't be papered over by zero'ing the > > allocation. > > Noob question, it's not the tag / AAD, right? We definitely don't init > that.. assoclen + cryptlen does not cover the tag on encryption, so it would be omitted here regardless of whether it was covered in the input scatterlist or not.